Refactor registry to return an error instead of panicking on duplicate registration
#2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on duplicate analysis component registration
CascadingRadium
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey and
Likith101
CascadingRadium
changed the title
registry to return an error instead of panicking on duplicate registration
abhinavdangeti
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registrypackage currentlypanicsor crashesBlevewhen a duplicate component is registered. This behavior makes it difficult to handle duplicate registrations gracefully and requires using a recover statement to prevent the application from crashing.Register<registry-component>to return an error instead of panicking when a duplicate registration is detected. This change would allow developers to check if a<registry-component>is already registered and handle it accordingly without relying on recover.